Skip to content

[v1.0.0 Alpha 1] JavascriptError @unchecked Sendable #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2022
Merged

[v1.0.0 Alpha 1] JavascriptError @unchecked Sendable #2147

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43aad75
fix: added unchecked sendable to JavascriptError to be able to compil…
TizianoCoroneo Feb 9, 2022
7df04c7
Update CircleCI to use latest images
calvincestari Feb 11, 2022
91cc3db
Change JavaScriptError properties to read-only
calvincestari Feb 11, 2022
6c984a1
Fix typo in header doc
calvincestari Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: added unchecked sendable to JavascriptError to be able to compil… 
…e with Swift 5.6
  • Loading branch information
@TizianoCoroneo
TizianoCoroneo committed Feb 9, 2022
commit 43aad75eea3dbcf4fc93abeac050d6c77a11a1ed
2 changes: 1 addition & 1 deletion Sources/ApolloCodegenLib/Frontend/JavaScriptBridge.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import JavaScriptCore

/// An errror thrown during JavaScript execution.
/// See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error
public class JavaScriptError: JavaScriptObject, Error {
public class JavaScriptError: JavaScriptObject, Error, @unchecked Sendable {
lazy var name: String? = self["name"]

lazy var message: String? = self["message"]
Expand Down