Skip to content

Add a comment about a new use of the X-APOLLO-OPERATION-NAME header #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnthonyMDev merged 1 commit into from
May 5, 2022
Merged

Add a comment about a new use of the X-APOLLO-OPERATION-NAME header #2267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add a comment about a new use of the X-APOLLO-OPERATION-NAME header
  • Loading branch information
@glasser
glasser authored May 5, 2022
commit 56e4755072d18b19d1ea1188bfafe6c599444fd5
9 changes: 9 additions & 0 deletions Sources/Apollo/HTTPRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ open class HTTPRequest<Operation: GraphQLOperation> {
self.cachePolicy = cachePolicy

self.addHeader(name: "Content-Type", value: contentType)
// Note: in addition to this being a generally useful header to send, Apollo
// Server's CSRF prevention feature (introduced in AS3.7 and intended to be
// the default in AS4) includes this in the set of headers that indicate
// that a GET request couldn't have been a non-preflighted simple request
// and thus is safe to execute. If this project is changed to not always
// send this header, its GET requests may be blocked by Apollo Server with
// CSRF prevention enabled. See
// https://www.apollographql.com/docs/apollo-server/security/cors/#preventing-cross-site-request-forgery-csrf
// for details.
self.addHeader(name: "X-APOLLO-OPERATION-NAME", value: self.operation.operationName)
self.addHeader(name: "X-APOLLO-OPERATION-TYPE", value: String(describing: operation.operationType))
if let operationID = self.operation.operationIdentifier {
Expand Down