This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Patch networkStatus along with loading attribute #2493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
JoviDeCroock
approved these changes
Oct 11, 2018
Author
|
@hwillson This is a pretty tiny and non-side-effective change. Can we please get it merged sooner? Thanks! |
hwillson
approved these changes
Oct 24, 2018
Member
hwillson
left a comment
hwillson
left a comment
There was a problem hiding this comment.
Awesome, thanks @steelbrain!
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #2003
While the above mentioned PR set the
loadingstatus on the partial merged data, clients using thenetworkStatusto infer loading state were breaking still. This fixesnetworkStatusto reflect the loading state correctly for partial refetching, thus patching that hole.Acknowledgements:
Thanks to @vafada for his help in investigating this
Edit: Rebased on master