Skip to content
This repository was archived by the owner on Apr 13, 2023. It is now read-only.

Fix problems with importing react-dom/server in React Native. #2593

Closed
benjamn wants to merge 12 commits into from
Closed

Fix problems with importing react-dom/server in React Native. #2593

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
616dc2d
Move react-dom from devDependencies to dependencies.
benjamn Nov 16, 2018
cddcaed
Update react and react-dom to their latest versions.
benjamn Nov 16, 2018
000f8a3
Skip failing walkTree tests.
benjamn Nov 16, 2018
df3bcb2
Update package-lock.json.
benjamn Nov 16, 2018
fbe1780
Make react-dom a peer dependency, like react.
benjamn Nov 17, 2018
302db38
Bump react-apollo to version 2.3.2-beta.0.
benjamn Nov 17, 2018
7a0c192
Override renderFunction for getDataFromTree when using React Native.
benjamn Nov 17, 2018
f9980b6
Bump react-apollo to version 2.3.2-beta.1.
benjamn Nov 17, 2018
209b142
Build a separate entry point bundle for React Native.
benjamn Nov 17, 2018
5a27ad0
Bump react-apollo to version 2.3.2-beta.2.
benjamn Nov 17, 2018
87184d2
Help React Native find the right entry point.
benjamn Nov 17, 2018
9f181b2
Bump react-apollo to version 2.3.2-beta.3.
benjamn Nov 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make react-dom a peer dependency, like react. 
If react-apollo depends directly on react-dom, and tries to be even a
little bit strict about the version, we run the risk of duplicating the
entire react-dom package, which is often one of the largest npm
dependencies in React-based apps.

A peer dependency won't automatically solve #2592, but it will provide an
important clue to the solution.
  • Loading branch information
@benjamn
benjamn committed Nov 17, 2018
commit fbe1780929d911201d2a4f9bc0cf463adb6cb0e3
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@
},
"peerDependencies": {
"apollo-client": "^2.3.8",
"react": "0.14.x || 15.* || ^15.0.0 || ^16.0.0",
Copy link
Member Author

@benjamn benjamn Nov 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hwillson @jbaxleyiii Is it reasonable to stop advertising support for [email protected] at this point? That version line was last published two years ago (0.14.9). Also, this is just a peer dependency, not actually a guarantee that react-apollo works with [email protected], which we probably don't anymore…

Copy link
Member

@hwillson hwillson Nov 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjamn Quite reasonable!

"react": "^15.0.0 || ^16.0.0",
"react-dom": "^15.0.0 || ^16.0.0",
"graphql": "^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0"
},
"devDependencies": {
Expand Down Expand Up @@ -127,6 +128,7 @@
"preact-compat": "3.18.4",
"prettier": "1.15.2",
"react": "16.6.3",
"react-dom": "16.6.3",
"react-test-renderer": "16.6.1",
"recompose": "0.30.0",
"recursive-rename": "2.0.0",
Expand All @@ -148,7 +150,6 @@
"invariant": "^2.2.2",
"lodash.flowright": "^3.5.0",
"lodash.isequal": "^4.5.0",
"prop-types": "^15.6.0",
"react-dom": "^16.6.3"
"prop-types": "^15.6.0"
}
}