Skip to content
This repository was archived by the owner on Apr 14, 2023. It is now read-only.

Fix on(eventName, cb, thisContext) readme doc#205

Merged
dotansimha merged 1 commit into
apollographql:masterfrom
ArnaudRinquin:patch-1
Jul 7, 2017
Merged

Fix on(eventName, cb, thisContext) readme doc#205
dotansimha merged 1 commit into
apollographql:masterfrom
ArnaudRinquin:patch-1

Conversation

@ArnaudRinquin

@ArnaudRinquin ArnaudRinquin commented Jul 4, 2017

Copy link
Copy Markdown
Contributor

By adjusting the eventName possible value to what they actually are.

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

By adjusting the `eventName` possible value to what they actually are.

@mistic mistic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread README.md

#### `on(eventName, callback, thisContext) => Function`
- `eventName: string`: the name of the event, available events are: `connect`, `reconnect` and `disconnect`
- `eventName: string`: the name of the event, available events are: `connecting`, `connected`, `reconnecting`, `reconnected` and `disconnected`

@mistic mistic Jul 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArnaudRinquin please add the full stop :)

@dotansimha
dotansimha merged commit 74f2ea4 into apollographql:master Jul 7, 2017
@dotansimha

Copy link
Copy Markdown
Contributor

Thanks @ArnaudRinquin !

@ArnaudRinquin
ArnaudRinquin deleted the patch-1 branch July 21, 2017 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants