This repository was archived by the owner on May 12, 2025. It is now read-only.
Merging upstream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ enable conversion webhook in webhook builder
✨ Fix typo
🐛 fix runnable run twice issue
✨ add GetConfigWithContext to retrieve a config with a specific context
IsConvertible used to use obj.GetObjectKind().GroupVersionKind() to get GVK which will not work if apiVersion and kind fields are not set. Now it uses scheme.ObjectKinds(obj).
🐛 IsConvertible should not error on uninitialized struct.
⚠️ metrics are now on by default
Signed-off-by: Brad Hoekstra <[email protected]>
🐛 Remove unused disableWebhookConfigInstaller flag
🏃 fix various typos
Logging the whole CRD resource is incredibly verbose as it includes every description of every field in the OpenAPI schema.
While the concrete Options struct documents delegating behavior, and the main overview documents it as well, this adds a note to manager#GetClient that it may return a non-live client, just to avoid confusion.
📖 Note on Manager#GetClient about delegating clients
- Currently validator interface supports create and update - Add support for delete as well, which could be a breaking change - Users need to implement ValidateDelete since interface is updated
Signed-off-by: hasheddan <[email protected]>
Signed-off-by: hasheddan <[email protected]>
When user tries to decode an object, it should always not be empty. This error gives people hints when they running into this kind of issues. e.g. kube-apiserver doesn't include the object in the admission review for deletion events.
✨ decoder now errors out when encountering an empty runtime.RawExtension
We now use https://golang.org/pkg/os/#TempDir to get the os specific temp dir. Otherwise, it won't work for Windows users.
⚠️ support delete validation in validator interface
These behave more-or-less like functional options, except that a given option can be applied to more than on option type, so we can deprecate the 3 different dryrunall variants. Things with arguments generally become type aliases, with the exception of MatchingField, which gets deprecated in favor of MatchFields (a type alias to fields.Set).
For field manager, update and create also support fieldmanager, so we allow using them there. For dryrun, it's also supported by delete, so we support setting it there.
🐛 stop using hardcoded temp dir
…redux⚠️ Functional Options Redux
…error-message 🐛 fix grammer of error in SetControllerReference
🏃 Remove usage of deprecated MatchingField list option
✨ Add Merge patch type and deprecate ConstantPatch in favor of RawPatch
Signed-off-by: Pires <[email protected]>
There is currently an unintuitive race condition between starting a cache, waiting for it to sync, and using it the first time. The crux of the problem is that WaitForCacheSync can return true BEFORE the Start function has had a chance to set started to true. This means that Get and List can return ErrCacheNotStarted even after WaitForCacheSync has returned true. This commit adds a channel and a wait function that is called from WaitForCacheSync to ensure that started has been set to true before returning.
📖 Rename "object" to "owned" to match godoc comment.
📖 docs: document the expected names of the TLS key and certificate
✨ update CRD if already present
🐛 wait for cache start before returning from WaitForCacheSync
A user may want to use different names for server key/cert, for example, if it's using the client-go cert manager util, the certificate is just a unify pem file with both on it. Signed-off-by: Quique Llorente <[email protected]>
Co-Authored-By: Adrián <[email protected]>
Co-Authored-By: Adrián <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
The log message that used this was removed in this commit 0f2e574#r36915807
📖 (:book:, docs) Remove references to 'download-binaries.sh'
✨ Parameterize webhook key/cert name
📖 Fix error in doc
🏃 Remove unused variable from IsConvertible
⚠ Add testenv support for CRDv1/CRDv1beta1 + update to k8s 1.16.4
🏃 (:running:, other) Fix makefile and docs for running tests
Add 'alenkacz' as reviewer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging upstream master