Skip to content

Strip any unescaped double-quotes from output #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boutell merged 1 commit into from
Jul 18, 2014
Merged

Strip any unescaped double-quotes from output #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,11 @@ function sanitizeHtml(html, options) {
result += ' ' + a;
if (value.length) {
// Values are ALREADY escaped, calling escapeHtml here
// results in double escapes
result += '="' + value + '"';
// results in double escapes.
// However, a bug in the HTML parser allows you to use malformed
// markup to slip unescaped quotes through, so we strip them explicitly.
// @see https://github.com/punkave/sanitize-html/issues/19
result += '="' + value.replace(/"/g, '"') + '"';
}
}
});
Expand Down