Skip to content

Reduce unstructured task #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2023
Merged

Reduce unstructured task #12

merged 2 commits into from
Oct 6, 2023

Conversation

yim-lee
Copy link
Member

@yim-lee yim-lee commented Oct 6, 2023

Motivation:
Feedback from @FranzBusch

Modification:

  • Use lock instead of actor to control access to ares_channel.
  • Handle task cancellation

yim-lee added 2 commits October 3, 2023 22:11
@yim-lee
Reduce unstructured Task usage
d375d46 
Motivation:
Feedback from @FranzBusch

Modification:
Use lock instead of actor to control access to `ares_channel`.
@yim-lee
Handle task cancellation
90b7e43
@yim-lee yim-lee requested a review from FranzBusch October 6, 2023 22:12
FranzBusch
FranzBusch approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing this.

@yim-lee yim-lee merged commit 3c1aae4 into apple:main Oct 6, 2023
@yim-lee yim-lee deleted the reduce-unstructured-task branch October 6, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yim-lee @FranzBusch