Move foundation extensions behind traits #81
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation Currently this package extends various Foundation types in a separate module. One problem with this module is that it unconditionally imports `FoundationNetworking`. This is undesirable on Linux since it brings `curl` as a dependency. Additionally, the discoverability of having to import an additional module isn't great. # Modification This PR introduces two new traits that enable extensions on types from `FoundationEssentials` and `FoundationNetworking` respectively. Giving adopters fine control of what they want to link against. It also moves all the extensions into the main `HTTPTypes` module. # Result Only a single module that is configurable through package traits.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently this package extends various Foundation types in a separate module. One problem with this module is that it unconditionally imports
FoundationNetworking. This is undesirable on Linux since it bringscurlas a dependency. Additionally, the discoverability of having to import an additional module isn't great.Modification
This PR introduces two new traits that enable extensions on types from
FoundationEssentialsandFoundationNetworkingrespectively. Giving adopters fine control of what they want to link against. It also moves all the extensions into the mainHTTPTypesmodule.Result
Only a single module that is configurable through package traits.