Replace os() with canImport(Darwin) #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
approved these changes
Jun 22, 2023
Contributor
|
@swift-server-bot add to allowlist |
Member
|
@swift-server-bot test this please |
Contributor
Author
|
@FranzBusch is this test failure related to the modification I've made? I was unable to relate the CI output with the changes applied here. |
Member
|
No this looks like our allocation counters need to be updated because we regressed somewhere. We should check where that allocation regression comes from. |
Lukasa
requested changes
Jun 23, 2023
Contributor
|
Alloc limits fix in #400 |
Contributor
Author
|
@Lukasa great catch! You nailed it. To be clear: I'm referring the |
Lukasa
approved these changes
Jun 23, 2023
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Love it, negative diffs are the best. ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable compiling the package to
xrOSusing the right code.