Skip to content

Conversation

@gwynne
Copy link
Contributor

@gwynne gwynne commented Nov 18, 2021

Fixes #99 (see issue for details).

@swift-server-bot
Copy link

Can one of the admins verify this patch?

5 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@Lukasa
Copy link
Contributor

Lukasa commented Nov 22, 2021

@swift-server-bot test this please

@Lukasa Lukasa added the 🆕 semver/minor Adds new public API. label Nov 22, 2021
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, LGTM!

@Lukasa
Copy link
Contributor

Lukasa commented Nov 22, 2021

@gwynne Mind cleaning up the soundness check and updating to the tip of main?

@Lukasa Lukasa merged commit eb4355b into apple:main Nov 22, 2021
@gwynne gwynne deleted the maxmessagesize-child-channel-option branch November 24, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 semver/minor Adds new public API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Child channels can not access their own peerMaxMessageSize

3 participants