Skip to content

fix lost file handle error #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukasa merged 2 commits into from
Jan 18, 2023
Merged

fix lost file handle error #129

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f40984
fix lost file handle error
maartene Jan 18, 2023
acda1eb
Merge branch 'main' into main
maartene Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix lost file handle error
  • Loading branch information
@maartene
maartene committed Jan 18, 2023
commit 5f409842c7298fd434363264c5ad70b1293940b1
2 changes: 1 addition & 1 deletion Sources/NIOSSHServer/ExecHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ final class ExampleExecHandler: ChannelDuplexHandler {
.channelOption(ChannelOptions.allowRemoteHalfClosure, value: true)
.channelInitializer { pipeChannel in
pipeChannel.pipeline.addHandler(theirs)
}.withPipes(inputDescriptor: outPipe.fileHandleForReading.fileDescriptor, outputDescriptor: inPipe.fileHandleForWriting.fileDescriptor).wait()
}.withPipes(inputDescriptor: dup(outPipe.fileHandleForReading.fileDescriptor), outputDescriptor: dup(inPipe.fileHandleForWriting.fileDescriptor)).wait()

// Ok, great, we've sorted stdout and stdin. For stderr we need a different strategy: we just park a thread for this.
DispatchQueue(label: "stderrorwhatever").async {
Expand Down