Support rekeying connections #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
reviewed
May 10, 2020
Contributor
|
I won't explicitly approve this, unless you'd want me to. I don't have anything else to add to these changes. |
artemredkin
approved these changes
May 12, 2020
Motivation: SSH allows peers to re-key active connections. While we don't immediately want to support positively doing that, we need to tolerate the possibility that the remote peer will initiate this rekeying. Modifications: - Extend the SSH Connection State Machine to propagate the needed information around. - Extend the key exchange state machine to handle previous session identifiers. - Add some tests. Results: We support rekeying now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SSH allows peers to re-key active connections. While we don't
immediately want to support positively doing that, we need to tolerate
the possibility that the remote peer will initiate this rekeying.
Modifications:
information around.
identifiers.
Results:
We support rekeying now!