Improve Sealed Box construction #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AES.GCM.SealedBox is expensive to construct from parts, in part because it's not inlinable. We can construct the combined representation directly and improve performance substantially by replacing 8 allocations with 3.
dnadoba
reviewed
Jan 23, 2023
| // As a workaround for a Swift Crypto inefficiency, we create the combined representation | ||
| // directly. | ||
| var combined: [UInt8] = [] | ||
| combined.reserveCapacity(12 + ciphertext.count + tag.count) |
Member
There was a problem hiding this comment.
can we add a comment that 12 is the size of nonce or can we make it a static property on SSHAESGCMNonce?
dnadoba
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AES.GCM.SealedBox is expensive to construct from parts, in part because it's not inlinable. We can construct the combined representation directly and improve performance substantially by replacing 8 allocations with 3.