Correctly resize ByteBuffers #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In two different places in this module we "reserve" space by moving the writer index forward. This isn't the correct way to do that, and it's a bit of a needless performance optimization. Instead, just write a zero in that location and come back to it. Modifications: - Replace unmotivated writer index move with a write. - Add tests. Result: Fewer crashes
glbrntt
approved these changes
Jun 29, 2023
|
|
||
| /// payload | ||
| self.moveWriterIndex(forwardBy: 5) | ||
| self.writeMultipleIntegers(UInt32(0), UInt8(0)) |
Contributor
There was a problem hiding this comment.
nit: there's also writeRepeatedBytes (or something similar to that) which might be a teeny tiny bit more obvious.
Contributor
Author
There was a problem hiding this comment.
Oh I actually thought this one made more sense given the packet format laid out above.
Contributor
There was a problem hiding this comment.
Makes sense, I was looking at it as the diff from “move the writer by 5”.
FranzBusch
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In two different places in this module we "reserve" space by moving the writer index forward. This isn't the correct way to do that, and it's a bit of a needless performance
optimization. Instead, just write a zero in that location and come back to it.
Modifications:
Result:
Fewer crashes