Skip to content

Fix some sendability warnings in tests #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeterAdams-A merged 3 commits into from
Aug 11, 2023
Merged

Fix some sendability warnings in tests #154

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75a9497
Fix some sendability warnings in tests
PeterAdams-A Aug 11, 2023
c26a83b
Better fix than main actor.
PeterAdams-A Aug 11, 2023
b969c64
Remove surplus space
PeterAdams-A Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix some sendability warnings in tests 
Motivation:

Swift concurrency warnings are here to help.
We can encode some of our assumptions to the type system.

Modifications:

Replace a number of captured variables with LoopBound instances.

Result:

Fewer sendability warnings
  • Loading branch information
@PeterAdams-A
PeterAdams-A committed Aug 11, 2023
commit 75a94977712707ed1bd66738b5b015f63f9f05b5
2 changes: 1 addition & 1 deletion Sources/NIOSSHPerformanceTester/Benchmark.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ protocol Benchmark: AnyObject {
func run() throws -> Int
}

func measureAndPrint<B: Benchmark>(desc: String, benchmark bench: B) throws {
@MainActor func measureAndPrint<B: Benchmark>(desc: String, benchmark bench: B) throws {
try bench.setUp()
defer {
bench.tearDown()
Expand Down
2 changes: 1 addition & 1 deletion Sources/NIOSSHPerformanceTester/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public func measure(_ fn: () throws -> Int) rethrows -> [TimeInterval] {

let limitSet = CommandLine.arguments.dropFirst()

public func measureAndPrint(desc: String, fn: () throws -> Int) rethrows {
@MainActor public func measureAndPrint(desc: String, fn: () throws -> Int) rethrows {
if limitSet.count == 0 || limitSet.contains(desc) {
print("measuring\(warning): \(desc): ", terminator: "")
let measurements = try measure(fn)
Expand Down
Loading