Skip to content

Fix some sendability warnings in tests #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeterAdams-A merged 3 commits into from
Aug 14, 2023
Merged

Fix some sendability warnings in tests #155

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afa45b2
Fix some sendability warnings in tests
PeterAdams-A Aug 11, 2023
6eb05e9
Please sense check
PeterAdams-A Aug 11, 2023
e371185
Fix soundness
PeterAdams-A Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Please sense check
  • Loading branch information
@PeterAdams-A
PeterAdams-A committed Aug 11, 2023
commit 6eb05e95ab019557e76feb2e7ef886c340cc2937
4 changes: 2 additions & 2 deletions Tests/NIOSSHTests/UserAuthenticationStateMachineTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ final class UserAuthenticationStateMachineTests: XCTestCase {
// For signed methods we need to be a bit careful: we can't assume that the signature will have a bitwise match, so we have to validate it
// instead.
if case .some(.publicKey(.known(let expectedKey, _))) = expectedMessage.map({ $0.method }),
case .some(.publicKey(.known(let actualKey, let actualSignature))) = request.value.map({ $0.method }),
case .some(.publicKey(.known(let actualKey, let actualSignature))) = request.value.map({ $0.method }),
let userAuthPayload = userAuthPayload {
XCTAssertEqual(expectedMessage!.username, request.value!.username)
XCTAssertEqual(expectedMessage!.service, request.value!.service)
Expand Down Expand Up @@ -180,7 +180,7 @@ final class UserAuthenticationStateMachineTests: XCTestCase {
// For signed methods we need to be a bit careful: we can't assume that the signature will have a bitwise match, so we have to validate it
// instead.
if case .some(.publicKey(.known(let expectedKey, _))) = expectedMessage.map({ $0.method }),
case .some(.publicKey(.known(let actualKey, let actualSignature))) = request.value.map({ $0.method }),
case .some(.publicKey(.known(let actualKey, let actualSignature))) = request.value.map({ $0.method }),
let userAuthPayload = userAuthPayload {
XCTAssertEqual(expectedMessage!.username, request.value!.username)
XCTAssertEqual(expectedMessage!.service, request.value!.service)
Expand Down