Skip to content

Conversation

@rnro
Copy link
Contributor

@rnro rnro commented Oct 25, 2024

Motivation:

This will allow us to decommission the old CI hooks.

Modifications:

  • Migrate the existing tests to use the package-benchmark framework.
  • Delete the obsolete integration tests and docker files.

Result:

Allocation counts are checked using GitHub Actions.

@rnro rnro force-pushed the github_actions_benchmarks branch from 21dcfc4 to 2d25227 Compare October 25, 2024 10:28
@rnro rnro added the semver/none No version bump required. label Oct 25, 2024
@rnro rnro force-pushed the github_actions_benchmarks branch 3 times, most recently from bca0341 to 7c5706c Compare October 25, 2024 11:27
@rnro rnro requested a review from Lukasa October 25, 2024 11:34
Motivation:

This will allow us to decommission the old CI hooks.

Modifications:

* Migrate the existing tests to use the package-benchmark framework.
* Delete the obsolete integration tests and docker files.

Result:

Allocation counts are checked using GitHub Actions.
@rnro rnro force-pushed the github_actions_benchmarks branch from 2af9a84 to 95358c3 Compare October 25, 2024 13:24
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks @rnro!

Copy link
Member

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Love that we migrated all of this over!

@Lukasa Lukasa merged commit 0cfe84f into main Oct 25, 2024
35 checks passed
@Lukasa Lukasa deleted the github_actions_benchmarks branch October 25, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants