Fix build on all platforms #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It turns out that PR 183 broke the build on a number of platforms, including Linux 6.1+, Android 6.1+, and on 6.0 macOS. We need to keep things building. Modifications: Guard the import of CDispatch Remove the use of replacingOccurrences Result: Better builds.
rnro
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It turns out that #183 broke the build on a number of platforms, including Linux 6.1+, Android 6.1+, and on 6.0 macOS. We need to keep things building.
Modifications:
Guard the import of CDispatch
Remove the use of replacingOccurrences
Result:
Better builds.