Strict concurrency for tests #198
Merged
+114
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemredkin
reviewed
Mar 31, 2025
| channel.eventLoop.makeFailedFuture(MultiplexerTestError.rejected) | ||
| channel.eventLoop.makeCompletedFuture { | ||
| let sync = channel.pipeline.syncOperations | ||
| try sync.addHandler(errorLogger) |
Contributor
There was a problem hiding this comment.
nit: any reason we need sync variable? why not just chain?
Contributor
Author
There was a problem hiding this comment.
No reason beyond habit!
artemredkin
reviewed
Mar 31, 2025
| // Issue a write to the child. | ||
| var bytes = channel.allocator.buffer(capacity: 1024) | ||
| bytes.writeString("Hello from the unit tests") | ||
| XCTAssertThrowsError(try channel.writeAndFlush(SSHChannelData(type: .channel, data: .byteBuffer(bytes))).wait()) |
Contributor
There was a problem hiding this comment.
Do we need to rewrite this because of "non-sendable" warning on SSHChannelData? My PR should address this
Contributor
Author
There was a problem hiding this comment.
Good point, I'll fix these up.
artemredkin
reviewed
Mar 31, 2025
| buffer.writeString("Hello from the unit tests!") | ||
|
|
||
| for _ in 0..<5 { | ||
| channel.write(SSHChannelData(type: .channel, data: .byteBuffer(buffer)), promise: nil) |
artemredkin
reviewed
Mar 31, 2025
| let finalWriteComplete = NIOLoopBoundBox(false, eventLoop: channel.eventLoop) | ||
| let eofComplete = NIOLoopBoundBox(false, eventLoop: channel.eventLoop) | ||
|
|
||
| channel.write(SSHChannelData(type: .channel, data: .byteBuffer(buffer))).whenSuccess { |
artemredkin
reviewed
Mar 31, 2025
| // Now write some data. This fails immediately. | ||
| XCTAssertThrowsError( | ||
| try channel.write( | ||
| SSHChannelData(type: .channel, data: .byteBuffer(channel.allocator.buffer(capacity: 1024))) |
artemredkin
approved these changes
Mar 31, 2025
Contributor
artemredkin
left a comment
artemredkin
left a comment
There was a problem hiding this comment.
Coulpe of minor suggestions but otherwise looks good
glbrntt
commented
Mar 31, 2025
| channel.eventLoop.makeFailedFuture(MultiplexerTestError.rejected) | ||
| channel.eventLoop.makeCompletedFuture { | ||
| let sync = channel.pipeline.syncOperations | ||
| try sync.addHandler(errorLogger) |
Contributor
Author
There was a problem hiding this comment.
No reason beyond habit!
| // Issue a write to the child. | ||
| var bytes = channel.allocator.buffer(capacity: 1024) | ||
| bytes.writeString("Hello from the unit tests") | ||
| XCTAssertThrowsError(try channel.writeAndFlush(SSHChannelData(type: .channel, data: .byteBuffer(bytes))).wait()) |
Contributor
Author
There was a problem hiding this comment.
Good point, I'll fix these up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.