Skip to content

Conversation

@artemredkin
Copy link
Contributor

Motivation:
Since IOData now sendable we can mark SSHChannel data sendable as well. This is required if we want to wrap SSH channel in a NIOAsyncChannel that operates with SSHChannelData

Modifications:

  • Remove unavailable from sendable conformance

Result:

  • SSHChannelData is now sendable

Motivation:
Since IOData now sendable we can mark SSHChannel data sendable as well.
This is required if we want to wrap SSH channel in a NIOAsyncChannel
that operates with SSHChannelData

Modifications:
 - Remove unavailable from sendable conformance

Result:
 - SSHChannelData is now sendable
@artemredkin artemredkin requested review from gjcairo and glbrntt March 31, 2025 09:42
@artemredkin artemredkin added the 🔨 semver/patch No public API change. label Mar 31, 2025
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@artemredkin artemredkin merged commit bcf6f4b into apple:main Mar 31, 2025
28 of 29 checks passed
@artemredkin artemredkin deleted the make_ssh_channel_data_sendable branch March 31, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants