Tolerate IGNORE and DEBUG messages. #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The SSH specification allows sending these messages more-or-less whenever an implementation wants, but does not mandate that a receiving implementation do anything with them. We should tolerate receiving them. Modifications: - Added support for parsing SSH_MSG_DEBUG. - Supported ignoring received messages of type DEBUG and IGNORE. - Supported sending DEBUG and IGNORE messages internally. Result: We'll ignore DEBUG and IGNORE messages.
Joannis
approved these changes
May 11, 2020
Contributor
Joannis
left a comment
Joannis
left a comment
There was a problem hiding this comment.
This looks perfect. I'd change nothing.
artemredkin
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The SSH specification allows sending these messages more-or-less
whenever an implementation wants, but does not mandate that a receiving
implementation do anything with them. We should tolerate receiving them.
Modifications:
Result:
We'll ignore DEBUG and IGNORE messages.
Resolves #20.