Add better support for error on receipt of unimplemented #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The unimplemented response is not deserialised. I think that adding the attached sequence id is of added value when debugging the SSH client. |
Contributor
Author
|
The deserialisation was implemented a while ago, so I didn't need to write it here. |
Contributor
|
I'll grab a cup of coffee. That makes sense. |
Contributor
Author
|
We now log the sequence ID as well. |
artemredkin
approved these changes
May 12, 2020
Motivation: When we receive the SSH_MSG_UNIMPLEMENTED it's because we sent a message the remote peer does not understand. We can't do much about this, but we can construct an error that is clearer about what exactly happened instead of using a generic protocol error. Modifications: - Better erroring on receipt of SSH_MSG_UNIMPLEMENTED. Result: Users will be less confused if this happens.
Joannis
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When we receive the SSH_MSG_UNIMPLEMENTED it's because we sent a message
the remote peer does not understand. We can't do much about this, but we
can construct an error that is clearer about what exactly happened
instead of using a generic protocol error.
Modifications:
Result:
Users will be less confused if this happens.
Resolves #21.