Don't install Jazzy on Xenial #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Ruby on Xenial is too old for the cocoapods downloader which jazzy uses. Modifications: Change Dockerfile to not install Jazzy on xenial. Result: Dockerfile will build again, but bionic or later is required for docs.
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Contributor
|
@swift-server-bot add to whitelist |
Lukasa
approved these changes
Jul 21, 2020
artemredkin
pushed a commit
to artemredkin/swift-nio-ssh
that referenced
this pull request
Feb 19, 2021
Motivation: Ruby on Xenial is too old for the cocoapods downloader which jazzy uses. Modifications: Change Dockerfile to not install Jazzy on xenial. Result: Dockerfile will build again, but bionic or later is required for docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Ruby on Xenial is too old for the cocoapods downloader which jazzy uses.
Modifications:
Change Dockerfile to not install Jazzy on xenial.
Result:
Dockerfile will build again, but bionic or later is required for docs.