Do not hold on to pending channels after close. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We temporarily store channel creation requests in NIOSSHHandler before passing them to the multiplexer while we wait for the handshake to complete. This is fine, but if for any reason we get removed from the pipeline while we're still holding some, they must all be cancelled. Modifications: - Correctly cancel creation requests on handlerRemoved. - Verify behaviour in tests. Result: Fewer hangs on channel creation.
artemredkin
approved these changes
Aug 14, 2020
artemredkin
pushed a commit
to artemredkin/swift-nio-ssh
that referenced
this pull request
Feb 19, 2021
Motivation: We temporarily store channel creation requests in NIOSSHHandler before passing them to the multiplexer while we wait for the handshake to complete. This is fine, but if for any reason we get removed from the pipeline while we're still holding some, they must all be cancelled. Modifications: - Correctly cancel creation requests on handlerRemoved. - Verify behaviour in tests. Result: Fewer hangs on channel creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We temporarily store channel creation requests in NIOSSHHandler before
passing them to the multiplexer while we wait for the handshake to
complete. This is fine, but if for any reason we get removed from the
pipeline while we're still holding some, they must all be cancelled.
Modifications:
Result:
Fewer hangs on channel creation.
Actually fixes #36.