Skip to content

Speed up slow unit tests. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukasa merged 1 commit into from
Apr 29, 2020
Merged

Speed up slow unit tests. #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Speed up slow unit tests. 
Motivation:

One single test, testWeDealWithFlowControlProperly, was taking up to 16s
to run when the rest of the test suite would run in less than 1s. We
need to speed that test up.

Modifications:

Speedily initialize the bytes of the buffer.

Result:

Test now runs in 8ms.
  • Loading branch information
@Lukasa
Lukasa committed Apr 29, 2020
commit cd692f72f0f8e58da2a2a5733132ae56031932da
6 changes: 5 additions & 1 deletion Tests/NIOSSHTests/ChildChannelMultiplexerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,8 +1169,12 @@ final class ChildChannelMultiplexerTests: XCTestCase {
XCTAssertNoThrow(try harness.multiplexer.receiveMessage(self.openConfirmation(originalChannelID: channelID!, peerChannelID: 1)))

// The default window size is 1<<24 bytes. Sadly, we need a buffer that size.
// Sorry for the unsafe code, but otherwise this test takes _ages_.
var buffer = channel.allocator.buffer(capacity: (1 << 24) + 1)
buffer.writeBytes(repeatElement(0, count: (1 << 24) + 1))
buffer.writeWithUnsafeMutableBytes(minimumWritableBytes: (1 << 24) + 1) { ptr in
memset(ptr.baseAddress!, 0, (1 << 24) + 1)
return (1 << 24) + 1
}

// We're going to write one byte short.
XCTAssertEqual(harness.flushedMessages.count, 1)
Expand Down