Fix infinite loop. #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Unexpected messages in the key exchange phase could lead to infinite loops because we'd ignore them, but not mark them as processed. For now, as we handle a wider range of messages, we'll just consider unexpected messages errors. Modifications: - Replaced .noMessage with throwing in two cases. Result: No remote triggerable infinite loop. (cherry picked from commit c20aa24a07c404e14aab0147b5ba2aaca3d08390)
artemredkin
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Unexpected messages in the key exchange phase could lead to infinite
loops because we'd ignore them, but not mark them as processed. For now,
as we handle a wider range of messages, we'll just consider unexpected
messages errors.
Modifications:
Result:
No remote triggerable infinite loop.