Skip to content

Add ChannelPipeline.SynchronousOperations.Position #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukasa merged 11 commits into from
Feb 4, 2025
Merged

Add ChannelPipeline.SynchronousOperations.Position #3065

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
09d6bcd
Add SynchronousOperations version of Position for non sendable handlers
0xTim Jan 16, 2025
7160c77
Add back ChannelPipeline functions and mark them as deprecated
0xTim Jan 17, 2025
e1c75f7
Add deprecated versions of the old HTTPPipelineSetup functions
0xTim Jan 17, 2025
225bdf7
Merge branch 'main' into non-sendadle-sync-position
0xTim Jan 17, 2025
ed47fb1
Do the conversions on the event loop to ensure we're safe
0xTim Feb 2, 2025
c6aea19
Merge branch 'main' into non-sendadle-sync-position
0xTim Feb 2, 2025
bb4a2d6
Add tests for sync position
0xTim Feb 3, 2025
6b0e2bf
Merge branch 'main' into non-sendadle-sync-position
0xTim Feb 3, 2025
1c647de
🤦‍♂️
0xTim Feb 3, 2025
863e209
Formatting
0xTim Feb 3, 2025
e68f3ff
Merge branch 'main' into non-sendadle-sync-position
Lukasa Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🤦‍♂️
  • Loading branch information
@0xTim
0xTim committed Feb 3, 2025
commit 1c647ded3534bf6677c9610b3cc68fd1c07b286d
16 changes: 8 additions & 8 deletions Tests/NIOPosixTests/ChannelPipelineTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2701,13 +2701,13 @@ class ChannelPipelineTest: XCTestCase {
}

let firstHandler = IndexWritingHandler(1)
XCTAssertNoThrow(try channel.pipeline.addHandler(firstHandler).wait())
XCTAssertNoThrow(try channel.pipeline.addHandler(IndexWritingHandler(2)).wait())
XCTAssertNoThrow(try channel.pipeline.syncOperations.addHandler(firstHandler))
XCTAssertNoThrow(try channel.pipeline.syncOperations.addHandler(IndexWritingHandler(2)))
XCTAssertNoThrow(
try channel.pipeline.addHandler(
try channel.pipeline.syncOperations.addHandler(
IndexWritingHandler(3),
position: .after(firstHandler)
).wait()
)
)

channel.assertReadIndexOrder([1, 3, 2])
Expand All @@ -2721,13 +2721,13 @@ class ChannelPipelineTest: XCTestCase {
}

let secondHandler = IndexWritingHandler(2)
XCTAssertNoThrow(try channel.pipeline.addHandler(IndexWritingHandler(1)).wait())
XCTAssertNoThrow(try channel.pipeline.addHandler(secondHandler).wait())
XCTAssertNoThrow(try channel.pipeline.syncOperations.addHandler(IndexWritingHandler(1)))
XCTAssertNoThrow(try channel.pipeline.syncOperations.addHandler(secondHandler))
XCTAssertNoThrow(
try channel.pipeline.addHandler(
try channel.pipeline.syncOperations.addHandler(
IndexWritingHandler(3),
position: .before(secondHandler)
).wait()
)
)

channel.assertReadIndexOrder([1, 3, 2])
Expand Down
Loading