Skip to content

Base64EncodedData initializer taking an array slice shouldn't have a label #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2023
Merged

Base64EncodedData initializer taking an array slice shouldn't have a label #71

merged 2 commits into from
Nov 9, 2023

Conversation

PARAIPAN9
Copy link
Contributor

Motivation

Modifications

  • Remove init label argument from Base64EncodedData

Result

  • The Base64EncodedData init will be called without the label.

Test Plan

  • Adjust some tests from Test_OpenAPIValue

czechboy0
czechboy0 requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just added a few more suggestions of how to further improve the ergonomics of the type.

czechboy0
czechboy0 reviewed Nov 9, 2023
View reviewed changes
@czechboy0
Copy link
Contributor

@swift-server-bot test this please

@czechboy0 czechboy0 merged commit 9da9ad6 into apple:main Nov 9, 2023
@czechboy0 czechboy0 added 🔨 semver/patch No public API change. 🆕 semver/minor Adds new public API. and removed 🔨 semver/patch No public API change. labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czechboy0 czechboy0 czechboy0 approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base64EncodedData initializer taking an array slice shouldn't have a label
2 participants
@PARAIPAN9 @czechboy0