Make the ISO8601 date transcoder configurable #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czechboy0
commented
Jan 14, 2024
czechboy0
commented
Jan 14, 2024
czechboy0
commented
Jan 14, 2024
simonjbeaumont
approved these changes
Jan 16, 2024
|
@czechboy0 how to actually use new transcoder in projects? |
You specify the date transcoder when creating your client by providing it as a parameter to the Configuration initializer: https://swiftpackageindex.com/apple/swift-openapi-runtime/1.3.0/documentation/openapiruntime/configuration/init(datetranscoder:multipartboundarygenerator:) The default is |
|
@simonjbeaumont thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes apple/swift-openapi-generator#389.
Modifications
Add a way to configure the existing
ISO8601DateTranscoder.Result
Adopters can more easily use e.g. fractional seconds-based transcoder.
Test Plan
Added unit tests.