Skip to content

Implement FileDescriptor.memoryMap, FileDescriptor.memoryUnmap, and FileDescriptor.memorySync #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement FileDescriptor.memoryMap, FileDescriptor.memoryUnmap, and FileDescriptor.memorySync #68

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd96cc5
Implement `FileDescriptor.memoryMap`, `FileDescriptor.memoryUnmap`, a…
jsflax Nov 7, 2021
cadb849
Set `valueOnSuccess` for CInt/Int/_COffT mock methods to 0
jsflax Nov 7, 2021
a21e70d
Remove `MemorySyncKind.invalidated` field covered by `invalidateOther…
jsflax Nov 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove MemorySyncKind.invalidated field covered by `invalidateOther… 
…Mappings` parameter in `memorySync`
  • Loading branch information
@jsflax
jsflax committed Nov 7, 2021
commit a21e70dd650731a7af0ee92b4875e36dded12614
8 changes: 1 addition & 7 deletions Sources/System/FileOperations.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,8 +461,7 @@ extension FileDescriptor {
}

/// Determines whether memory sync should be
/// synchronous, asynchronous, and/or invalidate
/// other mappings of the same file.
/// synchronous, asynchronous.
@frozen
public struct MemorySyncKind: RawRepresentable, Hashable, Codable {
Copy link
Member

@lorentey lorentey Nov 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like MemoryMapKind, I think this should be modeling the original (open-ended) flags. It ought to be called MemorySyncFlags, and it needs to be an OptionSet, not an enum-like struct.

/// The raw C flag number.
Expand All @@ -483,11 +482,6 @@ extension FileDescriptor {
/// returns immediately.
@_alwaysEmitIntoClient
public static var asynchronous: MemorySyncKind { MemorySyncKind(rawValue: _MS_ASYNC) }
Copy link
Member

@lorentey lorentey Nov 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want MS_INVALIDATE here.

On Darwin, we probably also want to expose MS_KILLPAGES and MS_DEACTIVATE.

/// Asks to invalidate other mappings of the same file (so
/// that they can be updated with the fresh values just
/// written).
@_alwaysEmitIntoClient
public static var invalidate: MemorySyncKind { MemorySyncKind(rawValue: _MS_INVALIDATE) }
}

/// Create a new mapping in the virtual address space of the
Expand Down