-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(db): store metadata as a file #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpacak
approved these changes
Apr 15, 2020
Contributor
danielpacak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Also run it on my local and it works as expected
GuaoGuao
pushed a commit
to GuaoGuao/trivy
that referenced
this pull request
Jun 24, 2020
* refactor: wrap errors * feat(db): add the metadata file * test(db): re-generate mocks * fix(app): read metadata from the file in showVersion * fix: open the database after downloading it * fix(operation): use UpdateMetadata * chore(mod): update dependency * test(integration): fix tests * fix(conf): rename TRIVY_NONSSL to TRIVY_NON_SSL
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
* refactor: wrap errors * feat(db): add the metadata file * test(db): re-generate mocks * fix(app): read metadata from the file in showVersion * fix: open the database after downloading it * fix(operation): use UpdateMetadata * chore(mod): update dependency * test(integration): fix tests * fix(conf): rename TRIVY_NONSSL to TRIVY_NON_SSL
josedonizetti
pushed a commit
to josedonizetti/trivy
that referenced
this pull request
Jun 24, 2022
…rity#493) * feat(check): Add separate check for SNS encryption with CMK Resolves aquasecurity#464 Signed-off-by: Liam Galvin <[email protected]> * docs: add missing docs * docs: add missing docs
black-leg-nameko
pushed a commit
to black-leg-nameko/trivy
that referenced
this pull request
Sep 16, 2025
* fix(gcp): properly check if bucket has logging Signed-off-by: Nikita Pivkin <[email protected]> * chore: require Trivy >= 0.66.0 for GCP-0077 Signed-off-by: Nikita Pivkin <[email protected]> --------- Signed-off-by: Nikita Pivkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/deprecation
Categorizes issue or PR as related to a feature/enhancement marked for deprecation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trivy --versionshows the database metadata, but we need to avoid opening the database because BoltDB can't be opened by two processes at the same time. So, this PR introducesmetadata.jsonwhich contains the database metadata such as schema version and next updated at. This file is stored after downloading the database successfully. Also, this file is removed before downloading the database. It means the database file is incomplete if there is notmetadata.jsonin a local file system.trivy --versioncan use this file instead of opening DB.