Skip to content

Serial monitor: added check when setting serial port parameters #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Serial monitor: added check when setting serial port parameters #3420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added check when setting serial port parameters 
This allows to detect for invalid baud rate settings in
particular on Linux where the kernel do not allow non-standard
baud rates on some devices.

See #3389
See #3351
  • Loading branch information
@cmaglie
cmaglie committed Jun 25, 2015
commit 3f57ed73898566a059c2130a1ecf9b51a0af5b65
6 changes: 5 additions & 1 deletion arduino-core/src/processing/app/Serial.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ private Serial(String iname, int irate, char iparity, int idatabits, float istop
try {
port = new SerialPort(iname);
port.openPort();
port.setParams(irate, idatabits, stopbits, parity, true, true);
boolean res = port.setParams(irate, idatabits, stopbits, parity, true, true);
if (!res) {
System.err.println(format(_("Error while setting serial port parameters: {0} {1} {2} {3}"),
irate, iparity, idatabits, istopbits));
}
port.addEventListener(this);
} catch (SerialPortException e) {
if (e.getPortName().startsWith("/dev") && SerialPortException.TYPE_PERMISSION_DENIED.equals(e.getExceptionType())) {
Expand Down