Skip to content

[PluggableHID] 2nd round of API improvement (WIP) #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 22 commits into from
Oct 7, 2015
Merged

[PluggableHID] 2nd round of API improvement (WIP) #3896

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3fe6272
[PUSB] PUSBCallback struct has been merged into PUSBListNode
cmaglie Sep 29, 2015
5aeff8e
[PUSB] Global functions PUSB_* are now methods of PluggableUSB class
cmaglie Sep 29, 2015
5e14b1f
[HID] Now HID extends directly PluggableUSBListNode
cmaglie Sep 29, 2015
8f259c8
[PUSB] Selected interface and endpoint are now part of PUSBListNode
cmaglie Sep 29, 2015
6ffd7e3
[PUSB] replaced u8 with uint8_t
cmaglie Sep 30, 2015
2ac2a27
[PUSB] Moved static members inside HID_ class
cmaglie Sep 30, 2015
0dfa815
[PUSB] callbacks are now pure virtual methods
cmaglie Sep 30, 2015
0369b8e
[PUSB] The latest fields are now set via constructor
cmaglie Sep 30, 2015
2d70691
[HID] Removed static fields in HID class
cmaglie Sep 30, 2015
9acbbe6
[PUSB] epType array is now part of HID class
cmaglie Sep 30, 2015
183ec1c
[PUSB] No more static fields in PluggableUSB class
cmaglie Sep 30, 2015
e823ef0
[PUSB] Fixed check for available endpoints
cmaglie Sep 30, 2015
d1f0c69
[PUSB] Fixed the correct number of endpoints
cmaglie Sep 30, 2015
1851fcc
[USB] Fixed some compiler warnings
cmaglie Sep 30, 2015
8a5ad75
[PUSB] Fixed checks on return values
cmaglie Oct 1, 2015
81aa7df
[HID] removed unused modules_count field
cmaglie Oct 1, 2015
214b260
[HID] Code cleanup (no semantic changes)
cmaglie Oct 1, 2015
d13aadc
[HID] removed HIDDescriptor field
cmaglie Oct 1, 2015
65b8430
[PUSB] Fix static initialization order fiasco
facchinm Oct 1, 2015
7fdb0ef
Removed not needed public statement for root node
NicoHood Oct 3, 2015
8bc21f7
Small return value error check correction
NicoHood Oct 3, 2015
5b1b033
[PUSB] renamed some parameters
cmaglie Oct 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[USB] Fixed some compiler warnings
  • Loading branch information
@cmaglie
cmaglie committed Oct 2, 2015
commit 1851fcc23c75e148dc6e165194c7295373146388
6 changes: 3 additions & 3 deletions hardware/arduino/avr/cores/arduino/USBCore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@

// bEndpointAddress in Endpoint Descriptor
#define USB_ENDPOINT_DIRECTION_MASK 0x80
#define USB_ENDPOINT_OUT(addr) ((addr) | 0x00)
#define USB_ENDPOINT_IN(addr) ((addr) | 0x80)
#define USB_ENDPOINT_OUT(addr) (lowByte((addr) | 0x00))
#define USB_ENDPOINT_IN(addr) (lowByte((addr) | 0x80))

#define USB_ENDPOINT_TYPE_MASK 0x03
#define USB_ENDPOINT_TYPE_CONTROL 0x00
Expand Down Expand Up @@ -277,4 +277,4 @@ typedef struct
#define D_CDCCS4(_subtype,_d0) { 4, 0x24, _subtype, _d0 }


#endif
#endif
3 changes: 1 addition & 2 deletions hardware/arduino/avr/libraries/HID/HID.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,7 @@ class HID_ : public PUSBListNode
uint8_t idle;
};

#define D_HIDREPORT(_descriptorLength) \
{ 9, 0x21, 0x1, 0x1, 0, 1, 0x22, _descriptorLength & 0xFF, _descriptorLength >> 8 }
#define D_HIDREPORT(length) { 9, 0x21, 0x01, 0x01, 0, 1, 0x22, lowByte(length), highByte(length) }

#define WEAK __attribute__ ((weak))

Expand Down