-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Linux: Removed X11 requirement when running in command line mode #5578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fbe6bf3
Moved all initializations into Base constructor
cmaglie cf54cce
SplashScreenHelper output progress in console for text-only mode
cmaglie b73bc92
Moving some other graphic related parts into GUI initialization
cmaglie fedc2b6
Give sense to `isCommandLine()` method
cmaglie 8d84432
Prompt for sketchbook folder only if in GUI mode
cmaglie 21bcb64
Build menus only in gui mode
cmaglie df1841f
Initialize Editor only in GUI mode (part 1/3)
cmaglie 611ed08
Use PreferenceData.setBoolean() where appropriate
cmaglie ae99095
...now Verify works again... (part 2/3)
cmaglie 1a640f6
...and Upload too (part 3/3)
cmaglie 3d52de7
Removed useless `showEditor` parameter from `Base.handleOpen`
cmaglie 8eae641
Removed old prototype code from #2328 that is now in Base
cmaglie c363777
Reduce verbosity during downloads in text-only mode
cmaglie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
SplashScreenHelper output progress in console for text-only mode
This commit makes this changes: - SplashScreenHelper is now local in Base constructor - if SplashScreenHelper is instantiated with a null SplashScreen instance then it outputs progress in console and avoid to make calls to Swing toolkit - The parsing of command line arguments is anticipated so we can determine if we are in command line or GUI mode early and setup objects that produces output to not use graphics toolkits. - In this case the SplashScreenHelper is initialized with a real splashscreen only if we are in GUI mode
- Loading branch information
commit cf54cce6608010ac7d6a1007edea9953d796b7fc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now parseArgumentsPhase1 is moved up this far, it might be good to move it even further up so
BaseNoGui.initParameterscan just use the--preferences-filevalue as parsed byparser, instead of having to parse it iself. From a quick glance ofparseArgumentsPhase1, it seems this does not depend on the preferences file being loaded? This should probably be a different commit, of course.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately
parseArgumentsPhase1depends on preferences being loaded, it usesPreferencesDatain 3 or 4 places. Of course this smells like a bad design, the CommandLineParser class should only parse the command line and actions should be taken outside. I guess it's the result of trying to keep low the amount of changes involved in previous refactorings.(again, while doing this PR I tried also to fix this one, but dropped this task to focus on solving the X11 issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Sounds like the commandline parsing needs another refactor after this one then (or, at least a
parseArgumentsPhase0to just parse the preferences path).