Add virtual keyword to virtual method override, for clarity #5790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are already treated as virtual by the compiler anyway. Ideally we'd have the override keyword here too, but I'm not sure if the lcd compiler supports this.
facchinm
added
the
Architecture: SAM
Member
|
Moved to arduino/ArduinoCore-sam#5 |
Contributor
Author
|
What's the link between these two repos? Is one subtree merged into the other? |
Member
|
The sam folder was a leftover from AVR-only times. We are moving it in a way like https://github.com/arduino/ArduinoCore-samd, so the core is provided standalone with all the history extracted with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are already treated as virtual by the compiler anyway. Ideally we'd have
the override keyword here too, but I'm not sure if the lcd compiler supports
this.