Skip to content

NRF: Fix ThreadDebug on Nano 33 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2021
Merged

NRF: Fix ThreadDebug on Nano 33 #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
NRF: Fix ThreadDebug on Nano 33 
* ThreadDebug does Not work with the debugging monitor disabled.
* Update the comment to reflect what this patch is doing exactly.
  • Loading branch information
@iabdalkader
iabdalkader committed Feb 18, 2021
commit c1abdc9d442c68be73b517c68a3d9361d28578aa
5 changes: 2 additions & 3 deletions variants/ARDUINO_NANO33BLE/variant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,8 @@ void initVariant() {
pinMode(LED_PWR, OUTPUT);
digitalWrite(LED_PWR, HIGH);

// Errata Nano33BLE - I2C pullup is on SWO line, need to disable TRACE
// was being enabled by nrfx_clock_anomaly_132
CoreDebug->DEMCR = 0;
// Errata Nano33BLE - I2C pullup is controlled by the SWO pin.
// Configure the TRACEMUX to disable routing SWO signal to pin.
NRF_CLOCK->TRACECONFIG = 0;

// FIXME: bootloader enables interrupt on COMPARE[0], which we don't handle
Expand Down