Skip to content

GSM: Add cellular state machine events reporting #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 21, 2023
Merged

GSM: Add cellular state machine events reporting #767

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e507f0
PTYSerial: do not trace write data
pennam Nov 17, 2023
9d35b94
GSM: allow to enable and disable AT messages trace
pennam Nov 17, 2023
f4d7f33
GSM: remove unused define
pennam Nov 21, 2023
9a81f86
GSM: enable debugging without mbed trace
pennam Nov 21, 2023
c4065f5
GSM: limit the number of internal state machine retries to 6
pennam Nov 21, 2023
7d988ba
GSM: remove begin() retry logic
pennam Nov 21, 2023
aec787b
GSM: move reset logic inside a function
pennam Nov 21, 2023
02dfb64
GSM: add function to wait for modem ready with timeout
pennam Nov 21, 2023
fb10917
GSM: reorder function calls
pennam Nov 21, 2023
c00bdb9
GSM: add keywords file
pennam Nov 21, 2023
8b85c6b
mbed: add new GSM patches
pennam Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GSM: remove begin() retry logic 
  * Internal retries are handled in mbed cellular state machine. If needed user should implement its own retry logic in the sketch.
  • Loading branch information
@pennam
pennam committed Nov 21, 2023
commit 7d988ba7cf4e1edcaa69a477612aefe65a0c6292
29 changes: 10 additions & 19 deletions libraries/GSM/src/GSM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
#include "CellularInterface.h"
#include "GEMALTO_CINTERION_CellularStack.h"

#define MAXRETRY 3

arduino::CMUXClass *arduino::CMUXClass::get_default_instance()
{
static mbed::UnbufferedSerial serial(MBED_CONF_GEMALTO_CINTERION_TX, MBED_CONF_GEMALTO_CINTERION_RX, 115200);
Expand Down Expand Up @@ -102,24 +100,17 @@ int arduino::GSMClass::begin(const char* pin, const char* apn, const char* usern
_context->set_band(_band);

int connect_status = NSAPI_ERROR_AUTH_FAILURE;
uint8_t retryCount = 0;
while(connect_status != NSAPI_ERROR_OK && retryCount < MAXRETRY) {

connect_status = _context->connect(pin, apn, username, password);
retryCount++;

if (connect_status == NSAPI_ERROR_AUTH_FAILURE) {
DEBUG_ERROR("Authentication Failure. Exiting application.");
} else if (connect_status == NSAPI_ERROR_OK || connect_status == NSAPI_ERROR_IS_CONNECTED) {
connect_status = NSAPI_ERROR_OK;
DEBUG_INFO("Connection Established.");
} else if (retryCount > 2) {
DEBUG_ERROR("Fatal connection failure: %d", connect_status);
} else {
DEBUG_WARNING("Couldn't connect, will retry...");
continue;
}

DEBUG_INFO("Connecting...");
connect_status = _context->connect(pin, apn, username, password);

if (connect_status == NSAPI_ERROR_AUTH_FAILURE) {
DEBUG_ERROR("Authentication Failure. Exiting application.");
} else if (connect_status == NSAPI_ERROR_OK || connect_status == NSAPI_ERROR_IS_CONNECTED) {
connect_status = NSAPI_ERROR_OK;
DEBUG_INFO("Connection Established.");
} else {
DEBUG_ERROR("Couldn't connect.");
}

return connect_status == NSAPI_ERROR_OK ? 1 : 0;
Expand Down