Skip to content

Fix: Arduino_CAN::write return value incompatible with interface specification at ArduinoCore-API/HardwareCAN. #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix: Arduino_CAN::write return value incompatible with interface specification at ArduinoCore-API/HardwareCAN. #956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix: Arduino_CAN::write return value incompatible with interface spec… 
…ification at ArduinoCore-API/HardwareCAN.

This fixes #924.
  • Loading branch information
@aentinger
aentinger committed Sep 20, 2024
commit 382f4f4ba3b033809c31f3d1a06e9bba87589ca4
5 changes: 4 additions & 1 deletion libraries/Arduino_CAN/src/Arduino_CAN.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ int Arduino_CAN::write(CanMsg const & msg)
CANData,
is_standard_id ? CANStandard : CANExtended);

return _can.write(can_msg);
int const rc = _can.write(can_msg);
if (rc == 0) /* mbed returns 0 in case of failed CAN::write(). */
return -1; /* Note: provide named constant in ArduinoCore-API/HardwareCAN.h, i.e. CAN_WRITE_GENERIC_ERROR */
return 1;
}

size_t Arduino_CAN::available()
Expand Down