Skip to content

Add virtual keyword to virtual method override, for clarity #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add virtual keyword to virtual method override, for clarity #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add virtual keyword to virtual method override, for clarity 
These are already treated as virtual by the compiler anyway. Ideally we'd have
the override keyword here too, but I'm not sure if the lcd compiler supports
this.
  • Loading branch information
@eric-wieser @facchinm
eric-wieser authored and facchinm committed Jan 24, 2017
commit bd2ac8fd9e85b67e3c8934407b00f3567876a3fb
10 changes: 5 additions & 5 deletions cores/arduino/UARTClass.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ class UARTClass : public HardwareSerial
void begin(const uint32_t dwBaudRate);
void begin(const uint32_t dwBaudRate, const UARTModes config);
void end(void);
int available(void);
virtual int available(void);
int availableForWrite(void);
int peek(void);
int read(void);
void flush(void);
size_t write(const uint8_t c);
virtual int peek(void);
virtual int read(void);
virtual void flush(void);
virtual size_t write(const uint8_t c);
using Print::write; // pull in write(str) and write(buf, size) from Print

void setInterruptPriority(uint32_t priority);
Expand Down