Larger Buffer RingBuffer.h

[d3str0y3rport]

The increase of the buffer size to handle larger streams like the ones from GPS.

[Adminius]

why not let user define his own buffer size?

#ifndef defined(SERIAL_BUFFER_SIZE)
#define SERIAL_BUFFER_SIZE 64
#endif

[tuxedo0801]

@cmaglie @sandeepmistry Any comments on this?

[Adminius]

@d3str0y3rport sorry, i made a mistake:

1. possibility:
   #ifndef SERIAL_BUFFER_SIZE
2. possibility
   #if !defined(SERIAL_BUFFER_SIZE)
   see also: https://github.com/arduino/ArduinoCore-avr/blob/master/cores/arduino/HardwareSerial.h#L42

[keestux]

Can you also show how and where you would define a different value? You'd have to define SERIAL_BUFFER_SIZE in the right place.

And what about if you have an application with multiple modules (one .ino and one or more .cpp)? Each module may or may not include Arduino.h (or Uart.h, or RingBuffer.h). If you don't set the same SERIAL_BUFFER_SIZE everywhere then you're screwed.

[keestux]

Another note. Each Uart has 2 ringbuffers. That means the data size increases quite a bit if the variant has 3 or 4 Serial devices.

[sandeepmistry]

Closing in favour of:
da9bfe8

[sandeepmistry]

@keestux

Can you also show how and where you would define a different value?

This would have to be changed in the boards.txt entry of the variant you are using.