Fixing potential xxxtoa() issue with newer ARM GCC toolchain #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thibaut VIARD <[email protected]>
|
@aethaniel thanks for submitting! Could you please expand on the potential issue? I think we have bigger problems, as Arduino.h includes both Would a better solution be to wrap some of the contents of |
|
I'm going to close this for now, we can revisit when the GCC version for the SAMD core is updated. |
boseji
pushed a commit
to go-ut/combined-ArduinoCore-samd
that referenced
this pull request
May 30, 2020
* Fix pulseIn() on SAMD51 by writing it in plain C, so that the CM0+-specific pulse_asm won't need to be linked. The SAMD51 is fast enough that we can time pulses with micros() Tested with a bunch of pulse lengths from <1us to >1s * Implement a new delayMicroseconds() function for SAMD51 This version enables the "Debug Watchpoint and Trace" module (DWT) in startup.c and then uses the 32bit cycle counter that is part of DWT to count cycles indepenent of instruction timing. Tested for good accuracy with various values between 1 and 2000us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fix potential issue coming with newlib integrated at least since ARM GCC 4.9 2015q2:
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=32c96ddd14acadc82e7fccf110367ec3c8320c85
Some tests have been done without breaking anything at the moment.
Only WString.cpp is using this API.
Signed-off-by: Thibaut VIARD [email protected]