Change gRPC upload functions to use new Port message

cli/arguments/arguments.go

@@ -0,0 +1,20 @@
+// This file is part of arduino-cli.
+//
+// Copyright 2020 ARDUINO SA (http://www.arduino.cc/)
+//
+// This software is released under the GNU General Public License version 3,
+// which covers the main part of arduino-cli.
+// The terms of this license can be found at:
+// https://www.gnu.org/licenses/gpl-3.0.en.html
+//
+// You can be released from the requirements of the above licenses by purchasing
+// a commercial license. Buying such a license is mandatory if you want to
+// modify or otherwise use the software for commercial activities involving the
+// Arduino software without disclosing the source code of your own applications.
+// To purchase a commercial license, send an email to [email protected].
+
+package arguments
+
+import "github.com/arduino/arduino-cli/i18n"
+
+var tr = i18n.Tr

cli/arguments/port.go

@@ -38,8 +38,8 @@ type Port struct {
 
 // AddToCommand adds the flags used to set port and protocol to the specified Command
 func (p *Port) AddToCommand(cmd *cobra.Command) {
-	cmd.Flags().StringVarP(&p.address, "port", "p", "", "Upload port address, e.g.: COM3 or /dev/ttyACM2")
-	cmd.Flags().StringVarP(&p.protocol, "protocol", "l", "", "Upload port protocol, e.g: serial")
+	cmd.Flags().StringVarP(&p.address, "port", "p", "", tr("Upload port address, e.g.: COM3 or /dev/ttyACM2"))
+	cmd.Flags().StringVarP(&p.protocol, "protocol", "l", "", tr("Upload port protocol, e.g: serial"))
 }
 
 // GetPort returns the Port obtained by parsing command line arguments.

cli/arguments/sketch.go

@@ -20,13 +20,10 @@ import (
 
 	"github.com/arduino/arduino-cli/cli/errorcodes"
 	"github.com/arduino/arduino-cli/cli/feedback"
-	"github.com/arduino/arduino-cli/i18n"
 	"github.com/arduino/go-paths-helper"
 	"github.com/sirupsen/logrus"
 )
 
-var tr = i18n.Tr
-
 // InitSketchPath returns an instance of paths.Path pointing to sketchPath.
 // If sketchPath is an empty string returns the current working directory.
 func InitSketchPath(sketchPath string) *paths.Path {

cli/burnbootloader/burnbootloader.go

@@ -19,6 +19,7 @@ import (
 	"context"
 	"os"
 
+	"github.com/arduino/arduino-cli/cli/arguments"
 	"github.com/arduino/arduino-cli/cli/errorcodes"
 	"github.com/arduino/arduino-cli/cli/feedback"
 	"github.com/arduino/arduino-cli/cli/instance"
@@ -30,7 +31,7 @@ import (
 
 var (
 	fqbn       string
-	port       string
+	port       arguments.Port
 	verbose    bool
 	verify     bool
 	programmer string
@@ -50,7 +51,7 @@ func NewCommand() *cobra.Command {
 	}
 
 	burnBootloaderCommand.Flags().StringVarP(&fqbn, "fqbn", "b", "", tr("Fully Qualified Board Name, e.g.: arduino:avr:uno"))
-	burnBootloaderCommand.Flags().StringVarP(&port, "port", "p", "", tr("Upload port, e.g.: COM10 or /dev/ttyACM0"))
+	port.AddToCommand(burnBootloaderCommand)
 	burnBootloaderCommand.Flags().BoolVarP(&verify, "verify", "t", false, tr("Verify uploaded binary after the upload."))
 	burnBootloaderCommand.Flags().BoolVarP(&verbose, "verbose", "v", false, tr("Turns on verbose mode."))
 	burnBootloaderCommand.Flags().StringVarP(&programmer, "programmer", "P", "", tr("Use the specified programmer to upload."))
@@ -63,10 +64,17 @@ func NewCommand() *cobra.Command {
 func run(command *cobra.Command, args []string) {
 	instance := instance.CreateAndInit()
 
+	// We don't need a Sketch to upload a board's bootloader
+	discoveryPort, err := port.GetPort(instance, nil)
+	if err != nil {
+		feedback.Errorf("Error during Upload: %v", err)
+		os.Exit(errorcodes.ErrGeneric)
+	}
+
 	if _, err := upload.BurnBootloader(context.Background(), &rpc.BurnBootloaderRequest{
 		Instance:   instance,
 		Fqbn:       fqbn,
-		Port:       port,
+		Port:       discoveryPort.ToRPC(),
 		Verbose:    verbose,
 		Verify:     verify,
 		Programmer: programmer,

cli/compile/compile.go

@@ -22,6 +22,7 @@ import (
 	"fmt"
 	"os"
 
+	"github.com/arduino/arduino-cli/arduino/discovery"
 	"github.com/arduino/arduino-cli/arduino/sketch"
 	"github.com/arduino/arduino-cli/cli/arguments"
 	"github.com/arduino/arduino-cli/cli/feedback"
@@ -39,25 +40,25 @@ import (
 )
 
 var (
-	fqbn                    string   // Fully Qualified Board Name, e.g.: arduino:avr:uno.
-	showProperties          bool     // Show all build preferences used instead of compiling.
-	preprocess              bool     // Print preprocessed code to stdout.
-	buildCachePath          string   // Builds of 'core.a' are saved into this path to be cached and reused.
-	buildPath               string   // Path where to save compiled files.
-	buildProperties         []string // List of custom build properties separated by commas. Or can be used multiple times for multiple properties.
-	warnings                string   // Used to tell gcc which warning level to use.
-	verbose                 bool     // Turns on verbose mode.
-	quiet                   bool     // Suppresses almost every output.
-	vidPid                  string   // VID/PID specific build properties.
-	uploadAfterCompile      bool     // Upload the binary after the compilation.
-	port                    string   // Upload port, e.g.: COM10 or /dev/ttyACM0.
-	verify                  bool     // Upload, verify uploaded binary after the upload.
-	exportDir               string   // The compiled binary is written to this file
-	optimizeForDebug        bool     // Optimize compile output for debug, not for release
-	programmer              string   // Use the specified programmer to upload
-	clean                   bool     // Cleanup the build folder and do not use any cached build
-	compilationDatabaseOnly bool     // Only create compilation database without actually compiling
-	sourceOverrides         string   // Path to a .json file that contains a set of replacements of the sketch source code.
+	fqbn                    string         // Fully Qualified Board Name, e.g.: arduino:avr:uno.
+	showProperties          bool           // Show all build preferences used instead of compiling.
+	preprocess              bool           // Print preprocessed code to stdout.
+	buildCachePath          string         // Builds of 'core.a' are saved into this path to be cached and reused.
+	buildPath               string         // Path where to save compiled files.
+	buildProperties         []string       // List of custom build properties separated by commas. Or can be used multiple times for multiple properties.
+	warnings                string         // Used to tell gcc which warning level to use.
+	verbose                 bool           // Turns on verbose mode.
+	quiet                   bool           // Suppresses almost every output.
+	vidPid                  string         // VID/PID specific build properties.
+	uploadAfterCompile      bool           // Upload the binary after the compilation.
+	port                    arguments.Port // Upload port, e.g.: COM10 or /dev/ttyACM0.
+	verify                  bool           // Upload, verify uploaded binary after the upload.
+	exportDir               string         // The compiled binary is written to this file
+	optimizeForDebug        bool           // Optimize compile output for debug, not for release
+	programmer              string         // Use the specified programmer to upload
+	clean                   bool           // Cleanup the build folder and do not use any cached build
+	compilationDatabaseOnly bool           // Only create compilation database without actually compiling
+	sourceOverrides         string         // Path to a .json file that contains a set of replacements of the sketch source code.
 	// library and libraries sound similar but they're actually different.
 	// library expects a path to the root folder of one single library.
 	// libraries expects a path to a directory containing multiple libraries, similarly to the <directories.user>/libraries path.
@@ -97,7 +98,7 @@ func NewCommand() *cobra.Command {
 	command.Flags().BoolVarP(&verbose, "verbose", "v", false, tr("Optional, turns on verbose mode."))
 	command.Flags().BoolVar(&quiet, "quiet", false, tr("Optional, suppresses almost every output."))
 	command.Flags().BoolVarP(&uploadAfterCompile, "upload", "u", false, tr("Upload the binary after the compilation."))
-	command.Flags().StringVarP(&port, "port", "p", "", tr("Upload port, e.g.: COM10 or /dev/ttyACM0"))
+	port.AddToCommand(command)
 	command.Flags().BoolVarP(&verify, "verify", "t", false, tr("Verify uploaded binary after the upload."))
 	command.Flags().StringVar(&vidPid, "vid-pid", "", tr("When specified, VID/PID specific build properties are used, if board supports them."))
 	command.Flags().StringSliceVar(&library, "library", []string{},
@@ -189,11 +190,23 @@ func run(cmd *cobra.Command, args []string) {
 	}
 
 	if err == nil && uploadAfterCompile {
+
+		var sk *sketch.Sketch
+		sk, err = sketch.New(sketchPath)
+		if err != nil {
+
+		}
+		var discoveryPort *discovery.Port
+		discoveryPort, err = port.GetPort(inst, sk)
+		if err != nil {
+
+		}
+
 		uploadRequest := &rpc.UploadRequest{
 			Instance:   inst,
 			Fqbn:       fqbn,
 			SketchPath: sketchPath.String(),
-			Port:       port,
+			Port:       discoveryPort.ToRPC(),
 			Verbose:    verbose,
 			Verify:     verify,
 			ImportDir:  buildPath,

cli/upload/upload.go

@@ -33,7 +33,7 @@ import (
 
 var (
 	fqbn       string
-	port       string
+	port       arguments.Port
 	verbose    bool
 	verify     bool
 	importDir  string
@@ -56,7 +56,7 @@ func NewCommand() *cobra.Command {
 	}
 
 	uploadCommand.Flags().StringVarP(&fqbn, "fqbn", "b", "", tr("Fully Qualified Board Name, e.g.: arduino:avr:uno"))
-	uploadCommand.Flags().StringVarP(&port, "port", "p", "", tr("Upload port, e.g.: COM10 or /dev/ttyACM0"))
+	port.AddToCommand(uploadCommand)
 	uploadCommand.Flags().StringVarP(&importDir, "input-dir", "", "", tr("Directory containing binaries to upload."))
 	uploadCommand.Flags().StringVarP(&importFile, "input-file", "i", "", tr("Binary file to upload."))
 	uploadCommand.Flags().BoolVarP(&verify, "verify", "t", false, tr("Verify uploaded binary after the upload."))
@@ -91,11 +91,22 @@ func run(command *cobra.Command, args []string) {
 		}
 	}
 
+	sk, err := sketch.New(sketchPath)
+	if err != nil {
+		feedback.Errorf("Error during Upload: %v", err)
+		os.Exit(errorcodes.ErrGeneric)
+	}
+	discoveryPort, err := port.GetPort(instance, sk)
+	if err != nil {
+		feedback.Errorf("Error during Upload: %v", err)
+		os.Exit(errorcodes.ErrGeneric)
+	}
+
 	if _, err := upload.Upload(context.Background(), &rpc.UploadRequest{
 		Instance:   instance,
 		Fqbn:       fqbn,
 		SketchPath: sketchPath.String(),
-		Port:       port,
+		Port:       discoveryPort.ToRPC(),
 		Verbose:    verbose,
 		Verify:     verify,
 		ImportFile: importFile,

commands/upload/upload.go

@@ -19,7 +19,6 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"net/url"
 	"path/filepath"
 	"strings"
 
@@ -40,6 +39,22 @@ import (
 
 var tr = i18n.Tr
 
+// getToolId returns the ID of the tool that supports the action and protocol combination by searching in props.
+// Returns error if tool cannot be found.
+func getToolId(props *properties.Map, action, protocol string) (string, error) {
+	toolProperty := fmt.Sprintf("%s.tool.%s", action, protocol)
+	defaultToolProperty := fmt.Sprintf("%s.tool.default", action)
+
+	if t, ok := props.GetOk(toolProperty); ok {
+		return t, nil
+	} else if t, ok := props.GetOk(defaultToolProperty); ok {
+		// Fallback for platform that don't support the specified protocol for specified action:
+		// https://github.com/arduino/tooling-rfcs/blob/main/RFCs/0002-pluggable-discovery.md#support-for-default-fallback-allows-upload-without-a-port
+		return t, nil
+	}
+	return "", fmt.Errorf("cannot find tool: undefined '%s' property", toolProperty)
+}
+
 // Upload FIXMEDOC
 func Upload(ctx context.Context, req *rpc.UploadRequest, outStream io.Writer, errStream io.Writer) (*rpc.UploadResponse, error) {
 	logrus.Tracef("Upload %s on %s started", req.GetSketchPath(), req.GetFqbn())
@@ -98,7 +113,7 @@ func UsingProgrammer(ctx context.Context, req *rpc.UploadUsingProgrammerRequest,
 
 func runProgramAction(pm *packagemanager.PackageManager,
 	sk *sketch.Sketch,
-	importFile, importDir, fqbnIn, port string,
+	importFile, importDir, fqbnIn string, port *rpc.Port,
 	programmerID string,
 	verbose, verify, burnBootloader bool,
 	outStream, errStream io.Writer,
@@ -108,16 +123,6 @@ func runProgramAction(pm *packagemanager.PackageManager,
 		return fmt.Errorf(tr("no programmer specified for burning bootloader"))
 	}
 
-	// FIXME: make a specification on how a port is specified via command line
-	if port == "" && sk != nil && sk.Metadata != nil {
-		deviceURI, err := url.Parse(sk.Metadata.CPU.Port)
-		if err != nil {
-			return fmt.Errorf(tr("invalid Device URL format: %s"), err)
-		}
-		if deviceURI.Scheme == "serial" {
-			port = deviceURI.Host + deviceURI.Path
-		}
-	}
 	logrus.WithField("port", port).Tracef("Upload port")
 
 	if fqbnIn == "" && sk != nil && sk.Metadata != nil {
@@ -157,28 +162,23 @@ func runProgramAction(pm *packagemanager.PackageManager,
 	}
 
 	// Determine upload tool
-	var uploadToolID string
-	{
-		toolProperty := "upload.tool"
-		if burnBootloader {
-			toolProperty = "bootloader.tool"
-		} else if programmer != nil {
-			toolProperty = "program.tool"
-		}
-
-		// create a temporary configuration only for the selection of upload tool
-		props := properties.NewMap()
-		props.Merge(boardPlatform.Properties)
-		props.Merge(boardPlatform.RuntimeProperties())
-		props.Merge(boardProperties)
-		if programmer != nil {
-			props.Merge(programmer.Properties)
-		}
-		if t, ok := props.GetOk(toolProperty); ok {
-			uploadToolID = t
-		} else {
-			return fmt.Errorf(tr("cannot get programmer tool: undefined '%s' property"), toolProperty)
-		}
+	// create a temporary configuration only for the selection of upload tool
+	props := properties.NewMap()
+	props.Merge(boardPlatform.Properties)
+	props.Merge(boardPlatform.RuntimeProperties())
+	props.Merge(boardProperties)
+	if programmer != nil {
+		props.Merge(programmer.Properties)
+	}
+	action := "upload"
+	if burnBootloader {
+		action = "bootloader"
+	} else if programmer != nil {
+		action = "program"
+	}
+	uploadToolID, err := getToolId(props, action, port.Protocol)
+	if err != nil {
+		return err
 	}
 
 	var uploadToolPlatform *cores.PlatformRelease
@@ -302,7 +302,7 @@ func runProgramAction(pm *packagemanager.PackageManager,
 		wait := false
 		portToTouch := ""
 		if touch {
-			portToTouch = port
+			portToTouch = port.Address
 			// Waits for upload port only if a 1200bps touch is done
 			wait = uploadProperties.GetBoolean("upload.wait_for_upload_port")
 		}
@@ -352,18 +352,18 @@ func runProgramAction(pm *packagemanager.PackageManager,
 			outStream.Write([]byte(fmt.Sprintln()))
 		} else {
 			if newPort != "" {
-				actualPort = newPort
+				actualPort.Address = newPort
 			}
 		}
 	}
 
-	if actualPort != "" {
+	if actualPort.Address != "" {
 		// Set serial port property
-		uploadProperties.Set("serial.port", actualPort)
-		if strings.HasPrefix(actualPort, "/dev/") {
-			uploadProperties.Set("serial.port.file", actualPort[5:])
-		} else {
-			uploadProperties.Set("serial.port.file", actualPort)
+		uploadProperties.Set("serial.port", actualPort.Address)
+		if actualPort.Protocol == "serial" {
+			// This must be done only for serial ports
+			portFile := strings.TrimPrefix(actualPort.Address, "/dev/")
+			uploadProperties.Set("serial.port.file", portFile)
 		}
 	}