better handle some edge cases

internal/cli/monitor/monitor.go

@@ -98,6 +98,11 @@ func runMonitorCmd(
 		defaultPort, defaultProtocol string
 	)
 
+	// Flags takes maximum precedence over sketch.yaml
+	// If {--port --fqbn --profile} are set we ignore the profile.
+	// If both {--port --profile} are set we read the fqbn in the following order: profile -> default_fqbn -> discovery
+	// If only --port is set we read the fqbn in the following order: default_fqbn -> discovery
+	// If only --fqbn is set we read the port in the following order: default_port
 	sketchPath := arguments.InitSketchPath(sketchPathArg)
 	sketch, err := sk.LoadSketch(context.Background(), &rpc.LoadSketchRequest{SketchPath: sketchPath.String()})
 	if err != nil && !portArgs.IsPortFlagSet() {
@@ -108,6 +113,8 @@ func runMonitorCmd(
 	}
 	if sketch != nil {
 		defaultPort, defaultProtocol = sketch.GetDefaultPort(), sketch.GetDefaultProtocol()
+	}
+	if fqbnArg.String() == "" {
 		if profileArg.Get() == "" {
 			inst, profile = instance.CreateAndInitWithProfile(sketch.GetDefaultProfile().GetName(), sketchPath)
 		} else {

internal/integrationtest/monitor/monitor_test.go

@@ -154,6 +154,13 @@ yun.serial.disableDTR=true
 			require.Contains(t, string(stdout), "Configuration rts = off")
 			require.Contains(t, string(stdout), "Configuration dtr = off")
 		})
+
+		t.Run("FQBNFromSpecificProfile", func(t *testing.T) {
+			// The only way to assert we're picking up the fqbn specified from the profile is to provide a wrong value
+			_, stderr, err := cli.RunWithCustomInput(quitMonitor(), "monitor", "--raw", "--profile", "profile1", sketchWithPortAndFQBN)
+			require.Error(t, err)
+			require.Contains(t, string(stderr), "not an FQBN: broken_fqbn")
+		})
 	})
 
 	t.Run("WithPortFlag", func(t *testing.T) {
@@ -188,6 +195,13 @@ yun.serial.disableDTR=true
 			require.Contains(t, string(stdout), "Configuration rts = off")
 			require.Contains(t, string(stdout), "Configuration dtr = off")
 		})
+
+		t.Run("FQBNFromSpecificProfile", func(t *testing.T) {
+			// The only way to assert we're picking up the fqbn specified from the profile is to provide a wrong value
+			_, stderr, err := cli.RunWithCustomInput(quitMonitor(), "monitor", "-p", "/dev/ttyARGS", "--raw", "--profile", "profile1", sketchWithPortAndFQBN)
+			require.Error(t, err)
+			require.Contains(t, string(stderr), "not an FQBN: broken_fqbn")
+		})
 	})
 
 	t.Run("WithFQBNFlag", func(t *testing.T) {
@@ -218,6 +232,14 @@ yun.serial.disableDTR=true
 			require.Contains(t, string(stdout), "Configuration rts = off")
 			require.Contains(t, string(stdout), "Configuration dtr = on")
 		})
+
+		t.Run("IgnoreProfile", func(t *testing.T) {
+			stdout, _, err := cli.RunWithCustomInput(quitMonitor(), "monitor", "-b", "arduino:avr:uno", "--raw", "--profile", "profile1", sketchWithPortAndFQBN)
+			require.NoError(t, err)
+			require.Contains(t, string(stdout), "Opened port: /dev/ttyDEF")
+			require.Contains(t, string(stdout), "Configuration rts = off")
+			require.Contains(t, string(stdout), "Configuration dtr = on")
+		})
 	})
 
 	t.Run("WithPortAndFQBNFlags", func(t *testing.T) {
@@ -252,5 +274,13 @@ yun.serial.disableDTR=true
 			require.Contains(t, string(stdout), "Configuration rts = off")
 			require.Contains(t, string(stdout), "Configuration dtr = on")
 		})
+
+		t.Run("IgnoreProfile", func(t *testing.T) {
+			stdout, _, err := cli.RunWithCustomInput(quitMonitor(), "monitor", "-p", "/dev/ttyARGS", "-b", "arduino:avr:uno", "--raw", "--profile", "profile1", sketchWithPortAndFQBN)
+			require.NoError(t, err)
+			require.Contains(t, string(stdout), "Opened port: /dev/ttyARGS")
+			require.Contains(t, string(stdout), "Configuration rts = off")
+			require.Contains(t, string(stdout), "Configuration dtr = on")
+		})
 	})
 }

internal/integrationtest/monitor/testdata/SketchWithDefaultPortAndFQBN/sketch.yaml

@@ -1,2 +1,5 @@
 default_port: /dev/ttyDEF
 default_fqbn: arduino:avr:yun
+profiles:
+  profile1:
+    fqbn: "broken_fqbn"