Skip to content

Command sketch new do not join sketchbook path to sketch name if only sketchname is provided #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 11, 2019
Merged

Command sketch new do not join sketchbook path to sketch name if only sketchname is provided #396

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
dbacd62
poc of required mod for behavior alignment
Sep 5, 2019
5aae182
align current tests to new behaviour
Sep 5, 2019
142d440
align sketch new behaviour in sketch path parameter mangling adding p…
Sep 5, 2019
a16bc66
align sketch new behaviour in sketch path parameter mangling adding
Sep 9, 2019
0343785
add test for subpath
Sep 5, 2019
c9f2cd9
add fix test for subpath
Sep 5, 2019
24c337f
add `.ino` suffix trim
Sep 10, 2019
f4b227c
move sketch new test in separate test_new.py file
Sep 10, 2019
5a2eca1
add working_dir fixture to sandboxing sketch creation tests
Sep 10, 2019
f10ccc2
add e2e test for .ino strip
Sep 10, 2019
5d2664b
apply test_sketch.py to sketch test module name for consistency
Sep 10, 2019
c8ecd7f
update test lib invoke to 1.3.0 in requirements.txt
Sep 10, 2019
865b868
force pytest temp directory to be created in current dir
Sep 10, 2019
8fb0881
create local tmpdir only for windows-2019 VM
Sep 11, 2019
e21f5f0
add conditional step to test pipeline to overcome win VM behaviour in…
Sep 11, 2019
0c75cca
skip failing sketch new e2e tests in GA Win VM until we find the issu…
Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add .ino suffix trim
  • Loading branch information
Roberto Sora committed Sep 11, 2019
commit 24c337fe0f2f6b3ac252f1db3841d65940ba30d0
5 changes: 4 additions & 1 deletion cli/sketch/new.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"io/ioutil"
"os"
"path/filepath"
"strings"

"github.com/arduino/arduino-cli/cli/errorcodes"
"github.com/arduino/arduino-cli/cli/feedback"
Expand Down Expand Up @@ -48,7 +49,9 @@ void loop() {
`)

func runNewCommand(cmd *cobra.Command, args []string) {
sketchDir, err := filepath.Abs(args[0])
// Trim to avoid issues if user creates a sketch adding the .ino extesion to the name
trimmedSketchName := strings.TrimSuffix(args[0], ".ino")
sketchDir, err := filepath.Abs(trimmedSketchName)
if err != nil {
feedback.Errorf("Error creating sketch: %v", err)
os.Exit(errorcodes.ErrGeneric)
Expand Down