Skip to content

Add Jest for tests #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
damassi wants to merge 1 commit into from
+1,586 −41
Closed

Add Jest for tests #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ module.exports = {
"env": {
"es6": true,
"node": true,
"browser": true
"browser": true,
"jest": true
},
"parser": "babel-eslint",
"parserOptions": {
Expand Down
5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"predeploy": "sh scripts/predeploy.sh",
"mocha": "sh scripts/mocha.sh",
"test": "sh scripts/test.sh",
"jest": "jest",
"start-dev": "foreman start -f Procfile.dev",
"deploy-staging": "APP_NAME=ervell-staging S3_BUCKET=ervell-staging yarn deploy"
},
Expand Down Expand Up @@ -130,6 +131,7 @@
"ezel-assets": "git://github.com/arenahq/ezel-assets.git",
"friendly-errors-webpack-plugin": "^1.6.1",
"html5": "*",
"jest": "^23.4.1",
"mocha": "*",
"progress-bar-webpack-plugin": "^1.10.0",
"rewire": "https://registry.npmjs.org/rewire/-/rewire-2.5.2.tgz",
Expand All @@ -141,5 +143,8 @@
},
"optionalDependencies": {
"fsevents": "*"
},
"jest": {
"testURL": "http://localhost"
Copy link
Member Author

@damassi damassi Aug 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this once this patch is published. JSDom (used underneath Jest) made a change upstream and broke libs all across the internet.

Copy link
Member

@dzucconi dzucconi Aug 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx much

}
}
7 changes: 7 additions & 0 deletions react/util/__tests__/formatErrors.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import formatErrors from 'react/util/formatErrors';

describe('formatErrors', () => {
it('works', () => {
expect(() => formatErrors()).toThrow();
});
});
Loading