recompiler: remove static_assert(false) from a template#2219
Merged
LukeUsher merged 1 commit intoares-emulator:masterfrom Sep 15, 2025
Merged
recompiler: remove static_assert(false) from a template#2219LukeUsher merged 1 commit intoares-emulator:masterfrom
LukeUsher merged 1 commit intoares-emulator:masterfrom
Conversation
GCC evaluated the always failing assert before the constexprs leading to it, resulting in a compilation failure. As a workaround, we can move the 'imm64' case inside the else block and check for the type there, which also catches unhandled types at compile time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix that was supposed to go in as part of #2133 but got missing due to a rebase mishap.
I had to change the setup_arg template function to check unknown types a bit differently because static_assert is evaluated before instantiation https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p2593r1.html
GCC evaluated the always failing assert before the constexprs leading to it, resulting in a compilation failure. As a workaround, we can move the 'imm64' case inside the else block and check for the type there, which also catches unhandled types at compile time.