desktop-ui: fix ws orientation after savestate load at boot#2471
Open
awsms wants to merge 1 commit intoares-emulator:masterfrom
Open
desktop-ui: fix ws orientation after savestate load at boot#2471awsms wants to merge 1 commit intoares-emulator:masterfrom
awsms wants to merge 1 commit intoares-emulator:masterfrom
Conversation
WonderSwan and WonderSwan Color could boot with the screen rotated incorrectly when loading a savestate during startup (using `--save-state`). Reapply the PPU/Screen/Orientation setting after unserializing a state so the screen rotation matches the restored orientation.
Contributor
|
FYI - The Game Boy Advance core supports screen orientation as well and should likely be added along with this. I believe it is currently these 3 cores. |
Contributor
Author
Thanks for the heads up, do you know any games/event that could trigger the GBA to rotate in ares? |
Contributor
|
GBA orientation is triggered from the Orientation sub-menu, same as WS/WSC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WonderSwan and WonderSwan Color could boot with the screen rotated incorrectly when loading a savestate during startup (using
--save-state).Reapply the PPU/Screen/Orientation setting after unserializing a state so the screen rotation matches the restored orientation.