-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix(commit-server): remove unnecessary init container #22915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
crenshaw-dev
merged 1 commit into
argoproj:master
from
crenshaw-dev:commit-server-remove-init-container
May 9, 2025
Merged
fix(commit-server): remove unnecessary init container #22915
crenshaw-dev
merged 1 commit into
argoproj:master
from
crenshaw-dev:commit-server-remove-init-container
May 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22915 +/- ##
==========================================
+ Coverage 60.02% 60.06% +0.03%
==========================================
Files 344 344
Lines 57781 57781
==========================================
+ Hits 34684 34704 +20
+ Misses 20334 20318 -16
+ Partials 2763 2759 -4 ☔ View full report in Codecov by Sentry. |
agaudreault
approved these changes
May 9, 2025
LyhengTep
pushed a commit
to LyhengTep/argo-cd
that referenced
this pull request
May 10, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
ranakan19
pushed a commit
to ranakan19/argo-cd
that referenced
this pull request
May 20, 2025
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Kanika Rana <[email protected]>
olivergondza
pushed a commit
to olivergondza/argo-cd
that referenced
this pull request
May 20, 2025
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Oliver Gondža <[email protected]>
tylerrosnett
pushed a commit
to StateFarmIns/argo-cd
that referenced
this pull request
May 27, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
7 tasks
|
I get this while trying to apply 3.1.0 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an artifact left over from copying repo-server manifests. The cmp-server binary isn't needed for commit-server.