Skip to content

fix: resolve argocdService initialization issue in notifications CLI #24664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blakepettersson merged 5 commits into from
Sep 22, 2025
Merged

fix: resolve argocdService initialization issue in notifications CLI #24664

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
55ec556
fix: resolve argocdService initialization issue in notifications CLI
puretension Sep 19, 2025
b9042a1
fix: resolve golangci-lint issues in settings_test.go
puretension Sep 19, 2025
915a071
fix: modify GetFactorySettingsForCLI to use deferred pattern
puretension Sep 20, 2025
15a50cc
revert: restore original settings_test.go
puretension Sep 20, 2025
9330fac
Merge branch 'master' into fix/notifications-service-initialization-2…
puretension Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: resolve golangci-lint issues in settings_test.go 
- Fix gofumpt formatting by reordering imports
- Replace assert with require for error assertions per testifylint

Signed-off-by: puretension <[email protected]>
  • Loading branch information
@puretension
puretension committed Sep 19, 2025
commit b9042a1a9be7bf6b2c17610c8229c309ece7c6ea
9 changes: 4 additions & 5 deletions util/notification/settings/settings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
import (
"testing"

"github.com/stretchr/testify/assert"
corev1 "k8s.io/api/core/v1"

"github.com/argoproj/notifications-engine/pkg/api"

Check failure on line 6 in util/notification/settings/settings_test.go

View workflow job for this annotation

GitHub Actions / Lint Go code 

File is not properly formatted (gofumpt)
service "github.com/argoproj/argo-cd/v3/util/notification/argocd"
"github.com/stretchr/testify/require"
corev1 "k8s.io/api/core/v1"

Check failure on line 9 in util/notification/settings/settings_test.go

View workflow job for this annotation

GitHub Actions / Lint Go code 

File is not properly formatted (goimports)
)

func TestGetFactorySettingsDeferred_ServiceNotInitialized(t *testing.T) {
Expand All @@ -25,6 +24,6 @@
secret := &corev1.Secret{}

_, err := settings.InitGetVars(cfg, configMap, secret)
assert.Error(t, err)
assert.Contains(t, err.Error(), "argocdService is not initialized")
require.Error(t, err)
require.Contains(t, err.Error(), "argocdService is not initialized")
}
Loading